search

DataDog / cloudformation-template

Easily set up the Datadog AWS integration using CloudFormation
Apache License 2.0
34 stars 44 forks source link

add support for ap1 (site) in organisations #69

Closed upp22 closed 1 year ago

upp22 commented 1 year ago

Note: Please remember to review the contribution guidelines if you have not yet done so.

What does this PR do?

Adds support for AP1 to the organizations CF Template.

Motivation

As a user in the Asia Pacific region, I signed up for the trial and followed all instructions to integrate Datadog with my AWS accounts - we're using AWS Organisations. The stack set constantly failed despite following all instructions online and given by datadog support representative. Ultimately, this was due to my datadog account being ap1, and my CF template pointing somewhere else.

Testing Guidelines

Tested by running this CF template and ensuring ap1.datadoghq.com is selected as site.

  1. Add New AWS account in datadog
  2. Select 'Add Multiple Accounts'
  3. Click 'Launch Cloud Formation Stackset' => Opens CloudFormation Stacksets in AWS Management Console
  4. Uploaded modified 'main_organizations.yaml' file
  5. Fill API + APP Keys
  6. Select ap1.datadoghq.com from DatadogSite dropdown
  7. Continue with the rest of the process
  8. Ensure resources are built successfully

Additional Notes

Of course, we can just modify the CF Template - but this may make it easier for the next person.