DataDog / cloudformation-template

Easily set up the Datadog AWS integration using CloudFormation
Apache License 2.0
34 stars 44 forks source link

Policy Macro Template referenced from main.yaml is still on python 3.7 #72

Closed fszymanski-blvd closed 1 year ago

fszymanski-blvd commented 1 year ago

While looking into the python 3.7 lambda deprecation, I updated the datadog integration cloudformation template which fixed the python version of the forwarder lambda but not the policy macro lambda.

Digging in, I found that while the policy macro has been updated to python 3.9, the template in S3 that is used by main.yaml still is on python 3.7.

plumdog commented 1 year ago

Just to add the command I used to easily verify this from https://github.com/DataDog/cloudformation-template/pull/60#issuecomment-1704860588:

$ curl -s 'https://datadog-cloudformation-template.s3.amazonaws.com/aws/datadog_policy_macro.yaml' | yq .Resources.DatadogPolicyMacroMacroFunction.Properties.Runtime
python3.7

(Ideally, someone from Datadog would announce the release of this change, but if anyone notices that that command outputs python3.9, pinging this issue would be very helpful.)

plumdog commented 1 year ago

Per @RaphaelAllier's comment https://github.com/DataDog/cloudformation-template/pull/60#issuecomment-1713725803, the relevant change is now released:

$ curl -s 'https://datadog-cloudformation-template.s3.amazonaws.com/aws/datadog_policy_macro.yaml' | yq .Resources.DatadogPolicyMacroMacroFunction.Properties.Runtime
python3.9
fszymanski-blvd commented 1 year ago

Per @RaphaelAllier's comment #60 (comment), the relevant change is now released:

$ curl -s 'https://datadog-cloudformation-template.s3.amazonaws.com/aws/datadog_policy_macro.yaml' | yq .Resources.DatadogPolicyMacroMacroFunction.Properties.Runtime
python3.9

Thanks for the notification. I have a support ticket open about this right now so maybe that kickstarted something. I've confirmed that updating the root template properly updates the lambda

RaphaelAllier commented 1 year ago

I was taking care of this but went on PTO, apologies for the delay