DataDog / cloudformation-template

Easily set up the Datadog AWS integration using CloudFormation
Apache License 2.0
34 stars 42 forks source link

[AWSMC-755] Mask API and App key parameter values in AWS templates #83

Closed ktmq closed 5 months ago

ktmq commented 5 months ago

Note: Please remember to review the contribution guidelines if you have not yet done so.

What does this PR do?

Sets NoEcho option on Datadog API key and app key parameters to true in AWS templates, so the values of these secrets are not visible in plaintext in the Cloudformation UI.

Motivation

It's a security risk to have these otherwise secret API and app key values exposed in the AWS UI. These values are treated as secret in the Datadog UI, so they should be treated as secret elsewhere in users' stacks.

Testing Guidelines

I deployed the stacks from the updated template and confirmed that the values were obfuscated. Before: image

After:

image

Additional Notes

Anything else we should know when reviewing?