search

DataDog / datadog-agent-orb

CircleCI Orb for running the Datadog Agent on builds
MIT License
0 stars 5 forks source link

Reintroduce DD_SITE environment variable #5

Closed tetienne closed 2 years ago

tetienne commented 2 years ago

Describe Request:

With version 0.0.1 it was possible to set the site using DD_SITE env var. With current version 3.0.0, only a string parameter site is exposed. When the setup is used in multiple place, it’s kind of "painful" to each time fill the site. Would be nice to reintroduce DD_SITE.

Examples:

- datadog-agent/setup:
      site: datadoghq.eu

to 

- datadog-agent/setup

We declare the job calling this command with a context:

- test_back:
    context: datadog
cg14823 commented 2 years ago

I have updated the orb to automatically read DD_SITE and if not set it fallbacks to whatever was passed to the site parameter (or the default). Please let me know if this works for you.

tetienne commented 2 years ago

Hi, thx for your reactivity. Sadly, after updating the orb (datadog-agent: datadog/agent@3.1.0), and removing the site parameter, the DD_SITE is not taken into account. It was ok with the site parameter.

circleci@xxxxxx:~$ env | grep DD                                                               
DD_API_KEY=xxxxxxxxx
DD_ENV=ci                                                                                        
DD_SITE=datadoghq.eu
cg14823 commented 2 years ago

Sorry to hear that I'll have a look.

I have found the issue it is a typo on my part I'll try to fix it promptly and release a 3.1.1 version.

cg14823 commented 2 years ago

Should be fixed 😄

tetienne commented 2 years ago

This time we are good indeed 🙏