search

DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.88k stars 1.21k forks source link

Retrieve AWS instance tags via instance metadata service, not DescribeTags API call #10495

Open ctaintor opened 2 years ago

ctaintor commented 2 years ago

Describe what happened: The Datadog agent currently requires EC2:DescribeTags permissions to introspect an instance's tags. This can create problems due to potential for throttling but also makes installing the Datadog agent a bit more complex, since the instance profile must have these rights. AWS recently released the ability to get an instance's tags via the instance metadata service. The Datadog agent should use this.

Describe what you expected: Datadog to reduce its usage of AWS APIs

Steps to reproduce the issue:

Additional environment details (Operating System, Cloud provider, etc):

oshmyrko commented 2 months ago

@ctaintor This was implemented 2 years ago in https://github.com/DataDog/datadog-agent/commit/f393e6e7281456606f01e36281f7e7feb90ea022: https://github.com/DataDog/datadog-agent/blame/main/pkg/config/config_template.yaml#L376-L379