DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.85k stars 1.19k forks source link

[BUG] 60-sysprobe-check.sh is too chatty in Docker agent image #15187

Open artyom opened 1 year ago

artyom commented 1 year ago

Agent Environment

Agent version 7.41.1, pulled in from public.ecr.aws/datadog/agent:7 image:

$ docker run -it --rm public.ecr.aws/datadog/agent:7 /bin/bash
Unable to find image 'public.ecr.aws/datadog/agent:7' locally
7: Pulling from datadog/agent
6f935188a310: Already exists 
Digest: sha256:4992b38387ca6dbb732f3493ed66cdf5efe7e08154b7e9e4159b1735dbaabe3f
Status: Downloaded newer image for public.ecr.aws/datadog/agent:7
root@7173535d3eed:/# agent version
Agent 7.41.1 - Commit: 4f39b9e - Serialization version: v5.0.39 - Go version: go1.18.9
root@7173535d3eed:/# cat /etc/datadog-agent/system-probe.yaml
cat: /etc/datadog-agent/system-probe.yaml: No such file or directory

Describe what happened:

When agent container is configured via environment variables, without explicit configuration files provided, on container launch it will emit this line:

grep: /etc/datadog-agent/system-probe.yaml: No such file or directory

This originates from 60-sysprobe-check.sh script:

https://github.com/DataDog/datadog-agent/blob/360d2b23e0753006574ef2751eea1f749b1c3f87/Dockerfiles/agent/cont-init.d/60-sysprobe-check.sh#L3

Describe what you expected:

No unnecessary output.

Steps to reproduce the issue:

Launch agent container with some valid configuration, but don't provide it with any explicit configuration files.

Additional environment details (Operating System, Cloud provider, etc):

Observed in AWS Fargate.

seanorama commented 9 months ago

Still observed in 7.50.x. In my case, on Kubernetes.