search

DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.89k stars 1.21k forks source link

Fix comment about labels #15664

Open stevenpitts opened 1 year ago

stevenpitts commented 1 year ago

https://github.com/DataDog/datadog-agent/blob/611b21c96784793de88eb71d9afabbc9e3bd1da7/pkg/tagger/collectors/workloadmeta_extract.go#L95-L99

In these two comments, from image should be from container. We can see this later down:

https://github.com/DataDog/datadog-agent/blob/611b21c96784793de88eb71d9afabbc9e3bd1da7/pkg/tagger/collectors/workloadmeta_extract.go#L204

Containers often inherit labels from images, but that's not always the case. For example, my use case, ECS Fargate, does not copy image labels to container labels.

arlyon commented 1 year ago

Thanks for adding this. I was wondering why this wasn't working for me. Do you have any workaround for having fargate inherit image labels?