search

DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.83k stars 1.19k forks source link

clusterrole.yaml #2113

Open dazdaz opened 6 years ago

dazdaz commented 6 years ago

The RBAC manifest clusterole.yaml is for OpenShift and should be re-named to clusterrole-openshift.yaml. The apiGroups entry is : - apiGroups: ["quota.openshift.io"]

I suggest that a 2nd generic manifest template be made (which is compatible with Azure Kubernetes Service) and the apiGroups be changed to :

xvello commented 6 years ago

Hi @dazdaz and thanks for your feedback.

The apiserver should silently ignore unknown apiGroups, as they can be added dynamically via CustomResourceDefinitions for example. This is why we decided against duplicating the file.

Does kubectl apply -f rbac/clusterrole.yaml actually fail on your cluster? If so, could you please paste the output here?