dkirov-dd commented 3 months ago

What does this PR do?

Motivation

This is a follow-up to this PR, making the same addition for community python checks.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

OriginSubProduct and OriginProductDetail can be viewed using scott's proxy-dumper. Run the proxy-dumper and change dd_url to http://localhost:8081/. Run the agent. See that the correct OriginSubProduct and OriginProductDetail values being populated for the checks

pr-commenter[bot] commented 3 months ago

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38227376 --os-family=ubuntu

Note: This applies to commit 0a2b3f45

pr-commenter[bot] commented 3 months ago

Regression Detector

Regression Detector Results

Run ID: a8d90105-39ae-49b3-83ce-8521f70c5692 Metrics dashboard Target profiles

Baseline: d41ff6461c019fedd11af6b3b68cf699d8b45f85 Comparison: 0a2b3f4560575900cf4c1a5088f2bd152bad8cdf

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------|--------------------|----------|------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.77 | [-0.12, +1.67] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api_cpu%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | idle | memory utilization | +0.69 | [+0.66, +0.73] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aidle%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | basic_py_check | % cpu utilization | +0.65 | [-1.96, +3.27] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Abasic_py_check%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | otel_to_otel_logs | ingress throughput | +0.56 | [-0.25, +1.37] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aotel_to_otel_logs%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | file_tree | memory utilization | +0.48 | [+0.41, +0.55] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_tree%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.02 | [-4.68, +4.71] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Apycheck_1000_100byte_tags%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_dd_logs_filter_exclude%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) | | ➖ | tcp_syslog_to_blackhole | ingress throughput | -2.38 | [-14.95, +10.18] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_syslog_to_blackhole%20run_id%3Aa8d90105-39ae-49b3-83ce-8521f70c5692&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719989052000&to_ts=1720000452000&live=false) |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".

dkirov-dd commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.