DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.73k stars 1.17k forks source link

[e2e] mark TestUpgrade_Agent_OCI_then_DebRpm as flaky #27192

Closed pducolin closed 1 day ago

pducolin commented 2 days ago

What does this PR do?

Mark TestPackages/agent_centos_7_x86_64/TestUpgrade_Agent_OCI_then_DebRpm as flaky

Motivation

incident-28477

Centos7 is EOL and just changed its mirror list for yum. We need to update the list in our custom image and update the AMI id in platform.json and in test-infra-definitions

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pducolin commented 2 days ago

/merge

dd-devflow[bot] commented 2 days ago

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

pducolin commented 2 days ago

/merge -c

dd-devflow[bot] commented 2 days ago

:warning: MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

agent-platform-auto-pr[bot] commented 2 days ago

[Fast Unit Tests Report]

On pipeline 37977013 (CI Visibility). The following jobs did not run any unit tests:

Jobs: - tests_deb-arm64-py3 - tests_deb-x64-py3 - tests_flavor_dogstatsd_deb-x64 - tests_flavor_heroku_deb-x64 - tests_flavor_iot_deb-x64 - tests_rpm-arm64-py3 - tests_rpm-x64-py3 - tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

pr-commenter[bot] commented 2 days ago

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37977013 --os-family=ubuntu

Note: This applies to commit 6d8c5761

pr-commenter[bot] commented 2 days ago

Regression Detector

Regression Detector Results

Run ID: 059fda5f-f094-44d7-8b51-3872960b223f Metrics dashboard Target profiles

Baseline: b950f7465288dd82fc6fa862681bd93f25f9cd9d Comparison: 6d8c576184eaa7dbe342b934157f10c384a97ee4

Performance changes are noted in the perf column of each table:

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------|--------------------|----------|------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ➖ | file_tree | memory utilization | +1.46 | [+1.38, +1.55] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_tree%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.14 | [-11.87, +14.14] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_syslog_to_blackhole%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | idle | memory utilization | +0.12 | [+0.08, +0.16] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aidle%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_dd_logs_filter_exclude%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.24 | [-5.04, +4.55] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Apycheck_1000_100byte_tags%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | otel_to_otel_logs | ingress throughput | -0.38 | [-1.19, +0.43] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aotel_to_otel_logs%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | basic_py_check | % cpu utilization | -0.39 | [-3.07, +2.30] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Abasic_py_check%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) | | ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.42 | [-3.30, -1.54] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api_cpu%20run_id%3A059fda5f-f094-44d7-8b51-3872960b223f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719832852000&to_ts=1719844252000&live=false) |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".
pducolin commented 2 days ago

/merge

dd-devflow[bot] commented 2 days ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 2 days ago

:rotating_light: MergeQueue: This merge request is in error

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #devflow with those details!

pducolin commented 1 day ago

/merge

dd-devflow[bot] commented 1 day ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!