search

DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.73k stars 1.17k forks source link

NDM: Upgrade pro-bing to fix a windows only bug #27208

Closed FlorianVeaux closed 2 days ago

FlorianVeaux commented 3 days ago

Internal context: https://datadoghq.atlassian.net/wiki/spaces/II/pages/3860988548/BUG+Windows+Ping+Buffer+Issue

A windows-only issue affects the pro-bing library, described in this issue: https://github.com/prometheus-community/pro-bing/issues/34

With this PR, we replace the pro-bing version to the one from a personal fork from @ken-schneider. Once the PR is merged upstream, we'll move back to the main branch.

pr-commenter[bot] commented 3 days ago

Regression Detector

Regression Detector Results

Run ID: fb63d419-a0f0-41b0-a160-fe088e4d5e69 Metrics dashboard Target profiles

Baseline: 8779d4aae297b22e3bef8981a44665943bae895a Comparison: 3e3c1e4f6f5d81c1c2d2f9623117a64a325f033b

Performance changes are noted in the perf column of each table:

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------|--------------------|----------|-----------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ➖ | file_tree | memory utilization | +0.35 | [+0.30, +0.40] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_tree%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | idle | memory utilization | +0.32 | [+0.28, +0.36] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aidle%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | otel_to_otel_logs | ingress throughput | +0.16 | [-0.65, +0.97] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aotel_to_otel_logs%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_dd_logs_filter_exclude%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.75 | [-5.52, +4.02] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Apycheck_1000_100byte_tags%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | basic_py_check | % cpu utilization | -1.18 | [-3.78, +1.41] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Abasic_py_check%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.71 | [-2.59, -0.83] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api_cpu%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) | | ➖ | tcp_syslog_to_blackhole | ingress throughput | -3.61 | [-16.16, +8.94] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_syslog_to_blackhole%20run_id%3Afb63d419-a0f0-41b0-a160-fe088e4d5e69&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1720009630000&to_ts=1720021030000&live=false) |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".
ken-schneider commented 3 days ago

@FlorianVeaux would you mind pulling in the latest changes from the fork? I tested again and my calculation was slightly off.

It's unlikely we'd hit the issue ourselves, but it appears that the buffer needs to be large enough to hold: p.Size + (ipv4.HeaderLen+8)*2. Even though net doesn't give us the original IP header, the underlying buffer needs to be large enough to hold it

ken-schneider commented 2 days ago

/merge

dd-devflow[bot] commented 2 days ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!