[USMON-1023] - Run Event monitoring tests for all build mods

DataDog / datadog-agent

Main repository for Datadog Agent

https://docs.datadoghq.com/

Apache License 2.0

2.73k stars 1.17k forks source link

[USMON-1023] - Run Event monitoring tests for all build mods #27210

Closed guyarb closed 3 days ago

guyarb commented 3 days ago

What does this PR do?

Runs event monitoring tests for all build modes
Setup event stream monitoring (if needed) and process monitor only once per a suite run. In the leaf tests we register and de-register dedicated callbacks to verify the tests are working. Thus, we don't have to create over and over again the event monitoring for every leaf test.

Motivation

The setup/teardown time for the event monitoring, which takes 10s. Thus, running event monitoring tests are very expensive

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

agent-platform-auto-pr[bot] commented 3 days ago

[Fast Unit Tests Report]

On pipeline 38095466 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

- tests_deb-arm64-py3 - tests_deb-x64-py3 - tests_flavor_dogstatsd_deb-x64 - tests_flavor_heroku_deb-x64 - tests_flavor_iot_deb-x64 - tests_rpm-arm64-py3 - tests_rpm-x64-py3 - tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

pr-commenter[bot] commented 3 days ago

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38095466 --os-family=ubuntu

Note: This applies to commit f6002246

amitslavin commented 3 days ago

Setup event stream monitoring (if needed) and process monitor only once per a suite run. In the leaf tests we register and de-register dedicated callbacks to verify the tests are working. Thus, we don't have to create over and over again the event monitoring for every leaf test.

Can you share in the PR description the impact of this change? (before and after)

guyarb commented 3 days ago

/merge

dd-devflow[bot] commented 3 days ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

guyarb commented 3 days ago

Setup event stream monitoring (if needed) and process monitor only once per a suite run. In the leaf tests we register and de-register dedicated callbacks to verify the tests are working. Thus, we don't have to create over and over again the event monitoring for every leaf test.

Can you share in the PR description the impact of this change? (before and after)

overall no impact the first commit reduced about 1m from the total time of the tests, but the second commit consumed most of it