coignetp commented 3 days ago

What does this PR do?

Disable scenario tests to get the CI back to a stable state

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

agent-platform-auto-pr[bot] commented 3 days ago

[Fast Unit Tests Report]

On pipeline 38113999 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

- tests_deb-arm64-py3 - tests_deb-x64-py3 - tests_flavor_dogstatsd_deb-x64 - tests_flavor_heroku_deb-x64 - tests_flavor_iot_deb-x64 - tests_rpm-arm64-py3 - tests_rpm-x64-py3 - tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

coignetp commented 3 days ago

/merge

dd-devflow[bot] commented 3 days ago

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

pr-commenter[bot] commented 3 days ago

Regression Detector

Regression Detector Results

Run ID: c58ff312-12c5-42da-b135-5dfddf6d0989 Metrics dashboard Target profiles

Baseline: 18af93019cda4810e4f8eb3e42e11f8b5b6d87ce Comparison: 4728d9309d4cea280cae1559485a9c369e682a3c

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------|--------------------|----------|------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ➖ | basic_py_check | % cpu utilization | +0.75 | [-2.00, +3.50] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Abasic_py_check%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | otel_to_otel_logs | ingress throughput | +0.08 | [-0.73, +0.89] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aotel_to_otel_logs%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | idle | memory utilization | +0.00 | [-0.04, +0.04] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aidle%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_dd_logs_filter_exclude%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.25 | [-1.14, +0.63] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api_cpu%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.64 | [-13.31, +12.03] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_syslog_to_blackhole%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | file_tree | memory utilization | -1.32 | [-1.45, -1.19] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_tree%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) | | ➖ | pycheck_1000_100byte_tags | % cpu utilization | -3.31 | [-8.02, +1.40] | [Logs](https://app.datadoghq.com/logs?query=experiment%3Apycheck_1000_100byte_tags%20run_id%3Ac58ff312-12c5-42da-b135-5dfddf6d0989&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1719913598000&to_ts=1719924998000&live=false) |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".

pr-commenter[bot] commented 3 days ago

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38113999 --os-family=ubuntu

Note: This applies to commit 4728d930