search

DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.84k stars 1.19k forks source link

[USM] Add envoy configuration value #27230

Closed amitslavin closed 2 months ago

amitslavin commented 3 months ago

What does this PR do?

Add configuration value for envoyCmd.

Motivation

We currently try to determine whether a PID represents an Envoy process using this constant path: /proc/PID/bin/envoy.

We identified a situation where Envoy is being used by a symlink path that is different from this constant path.

For that reason, we have decided to use a configuration value for the Envoy path, which will allow us to update the searched path and include PIDs that are Envoy processes.

Additional Notes

I have created a follow-up task to implement path resolution and improve our current logic for identifying the Envoy process without needing a configuration value.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pr-commenter[bot] commented 3 months ago

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38121434 --os-family=ubuntu
amitslavin commented 2 months ago

Issue is being handled in the following PR: https://github.com/DataDog/datadog-agent/pull/27400