search

DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.9k stars 1.21k forks source link

remove `bundle_ebpf` flag from `inv agent.build` #31422

Closed paulcacheux closed 19 hours ago

paulcacheux commented 20 hours ago

What does this PR do?

This flag is now unused, it should have been removed as part of https://github.com/DataDog/datadog-agent/pull/31228

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

paulcacheux commented 20 hours ago

/merge

dd-devflow[bot] commented 20 hours ago

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-25 14:02:37 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

2024-11-25 14:49:23 UTC :information_source: MergeQueue: merge request added to the queue

The median merge time in main is 23m.

agent-platform-auto-pr[bot] commented 20 hours ago

[Fast Unit Tests Report]

On pipeline 49858701 (CI Visibility). The following jobs did not run any unit tests:

Jobs: - tests_deb-arm64-py3 - tests_deb-x64-py3 - tests_flavor_dogstatsd_deb-x64 - tests_flavor_heroku_deb-x64 - tests_flavor_iot_deb-x64 - tests_rpm-arm64-py3 - tests_rpm-x64-py3 - tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

cit-pr-commenter[bot] commented 19 hours ago

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 22150474-76ee-47c9-b507-1787b57ce453

Baseline: cfaf5ee0ba972b929169d2e1d24b61e0b2f50bd2 Comparison: 3e303d3e16348bd1d0cc30a41e46717b9521f99d Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links | |------|----------------------------------------------|--------------------|----------|----------------|--------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.84 | [+0.11, +1.57] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api_cpu%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | file_tree | memory utilization | +0.83 | [+0.70, +0.97] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_tree%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | quality_gate_idle | memory utilization | +0.48 | [+0.44, +0.53] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aquality_gate_idle%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) [bounds checks dashboard](https://app.datadoghq.com/dashboard/vz3-jd5-bdi?fromUser=true&refresh_mode=paused&tpl_var_experiment%5B0%5D=quality_gate_idle&tpl_var_job_id%5B0%5D=22150474-76ee-47c9-b507-1787b57ce453&tpl_var_run-id%5B0%5D=22150474-76ee-47c9-b507-1787b57ce453&view=spans&from_ts=1732544341000&to_ts=1732544941000&live=false) | | ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.44 | [+0.37, +0.52] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_syslog_to_blackhole%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.11 | [-0.66, +0.89] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_to_blackhole_1000ms_latency%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.08, +0.09] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Auds_dogstatsd_to_api%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Atcp_dd_logs_filter_exclude%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.82, +0.75] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_to_blackhole_0ms_latency%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.04 | [-0.80, +0.73] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_to_blackhole_500ms_latency%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.04 | [-0.51, +0.42] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_to_blackhole_1000ms_latency_linear_load%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.09 | [-0.81, +0.62] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_to_blackhole_100ms_latency%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.19 | [-0.82, +0.45] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Afile_to_blackhole_300ms_latency%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | quality_gate_idle_all_features | memory utilization | -0.61 | [-0.71, -0.52] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aquality_gate_idle_all_features%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) [bounds checks dashboard](https://app.datadoghq.com/dashboard/vz3-jd5-bdi?fromUser=true&refresh_mode=paused&tpl_var_experiment%5B0%5D=quality_gate_idle_all_features&tpl_var_job_id%5B0%5D=22150474-76ee-47c9-b507-1787b57ce453&tpl_var_run-id%5B0%5D=22150474-76ee-47c9-b507-1787b57ce453&view=spans&from_ts=1732544341000&to_ts=1732544941000&live=false) | | ➖ | otel_to_otel_logs | ingress throughput | -0.93 | [-1.61, -0.25] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aotel_to_otel_logs%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | basic_py_check | % cpu utilization | -4.09 | [-7.89, -0.29] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Abasic_py_check%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) | | ➖ | pycheck_lots_of_tags | % cpu utilization | -4.51 | [-7.87, -1.15] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Apycheck_lots_of_tags%20run_id%3A22150474-76ee-47c9-b507-1787b57ce453&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1732537141000&to_ts=1732548541000&live=false) |

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ file_to_blackhole_300ms_latency lost_bytes 9/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

**Confidence level:** 90.00% **Effect size tolerance:** |Δ mean %| ≥ 5.00% Performance changes are noted in the **perf** column of each table: * ✅ = significantly better comparison variant performance * ❌ = significantly worse comparison variant performance * ➖ = no significant change in performance A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.