DataDog / datadog-agent

Main repository for Datadog Agent
https://docs.datadoghq.com/
Apache License 2.0
2.9k stars 1.21k forks source link

Why is lowercase cluster name required? #6826

Open walkafwalka opened 4 years ago

walkafwalka commented 4 years ago
Error: template: datadog/templates/daemonset.yaml:88:12: executing "datadog/templates/daemonset.yaml" at <include "container-agent" .>: error calling include: template: datadog/templates/container-agent.yaml:16:8: executing "container-agent" at <include "containers-common-env" .>: error calling include: template: datadog/templates/containers-common-env.yaml:17:4: executing "containers-common-env" at <fail "Your `clusterName` isn’t valid. It must be dot-separated tokens where a token start with a lowercase letter followed by up to 39 lowercase letters, numbers, or hyphens and cannot end with a hyphen.">: error calling fail: Your `clusterName` isn’t valid. It must be dot-separated tokens where a token start with a lowercase letter followed by up to 39 lowercase letters, numbers, or hyphens and cannot end with a hyphen.

Describe what happened:

The Datadog agent requires a clustername with all lowercase characters. Is this a requirement due to a limitation? Unforunately, I cannot change all of my EKS clusters to lowercase.

Simwar commented 3 years ago

Hey @walkafwalka

Thanks for reporting this. Helm is complaining about the value you are setting in your values.yaml, so you should be able to change it, even though your real cluster names have uppercase characters in their names.

matthewhembree commented 3 years ago

Is there a specific reason for this validation? It's common for GKE clusters to have an underscore in their (kube_context) name.

I understand that clusterName: is just a canonical name in this context, but having it differ here versus the actual kubernetes context name could/would create confusion for users within the Datadog UI.