DataDog / datadog-cdk-constructs

CDK construct library to automagically instrument your Lambda functions with Datadog
Apache License 2.0
65 stars 28 forks source link

fix: make DatadogProps available in Python again #295

Closed lym953 closed 2 months ago

lym953 commented 2 months ago

What does this PR do?

Solves a few backward compatibility issues:

Motivation

Users reported that the class DatadogProps is no longer available in the Python package v2-1.16.0. https://github.com/DataDog/datadog-cdk-constructs/issues/294

Testing Guidelines

Steps

  1. Make changes on the example Python stack to make it use DatadogProps https://github.com/DataDog/datadog-cdk-constructs/commit/480eed099a4836360e72365db6edcd1af1d43d36
  2. Deploy the stack

    Result

    Before:

    • cdk deploy gives an error:

      ImportError: cannot import name 'DatadogProps' from 'datadog_cdk_constructs_v2'

After:

Additional Notes

Types of Changes

Check all that apply

lym953 commented 2 months ago

Since #288 is reverted, I'll rewrite the current PR and open another one.