Closed anmarchenko closed 9 months ago
Attention: 11 lines
in your changes are missing coverage. Please review.
Comparison is base (
b8ce942
) 99.05% compared to head (897abcc
) 97.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What does this PR do? Adds ci-queue support when using Minitest
Additional Notes ci-queue is a test runner developed and open sourced by Shopify. It runs Minitest and RSpec (deprecated) test suites in parallel using several workers and coordinating using redis queue.
ci-queue instrumentation for Minitest posed several challenges:
Minitest.extensions
directly which caused ci-queue to fail completelyminitest/datadog_ci_plugin.rb
file it still fails: ci-queue uses minitest-reporters gem that does not correctly work with minitest plugin system. Minitest-reporters gem simply replaces the framework reporters with its own reporters essentially discarding them. Author of minitest framework created an issue in minitest-reporters repository about this problem but it isn't resolved to this dayMinitest::CompositeReporter
class that is not being overwritten by minitest-reporters (yet?)How to test the change? Unit tests are provided