DataDog / datadog-ci-rb

Ruby library for Datadog test visibility
https://docs.datadoghq.com/continuous_integration/tests/ruby
Other
8 stars 4 forks source link

[NO TICKET] test code coverage with symlinked dependency required via entrypoint #188

Closed anmarchenko closed 4 months ago

anmarchenko commented 4 months ago

What does this PR do? This PR adds a test to assert that code coverage tool gets correct file paths when dependencies are located in symlinked folder and required via single entrypoint (emulating usage of local dependencies that are just symlinks to modules in minirepo).

Motivation Make sure that code coverage won't break in the future as this is known case for the monorepo setup.

How to test the change? This PR adds only unit tests.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 85.96491% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 98.86%. Comparing base (7869360) to head (2c33006).

Files Patch % Lines
...h_symlinks/operations/helpers/calculator_logger.rb 33.33% 4 Missing :warning:
spec/ddcov/calculator_with_symlinks/calculator.rb 86.66% 2 Missing :warning:
...dcov/calculator_with_symlinks/operations/divide.rb 80.00% 1 Missing :warning:
...ov/calculator_with_symlinks/operations/multiply.rb 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #188 +/- ## ========================================== - Coverage 98.93% 98.86% -0.08% ========================================== Files 221 228 +7 Lines 10039 10096 +57 Branches 466 466 ========================================== + Hits 9932 9981 +49 - Misses 107 115 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.