Security Vulnerability for ssh2@1.14.0

anushreepatil commented 7 months ago

Bug description

Currently, the latest version of @datadog/datadog-ci uses ssh2@1.14.0 which is vulnerable National Vulnerability Database CVE advisory for a medium severity issue

More Info: The SSH transport protocol with certain OpenSSH extensions, found in OpenSSH before 9.6 and other products, allows remote attackers to bypass integrity checks such that some packets are omitted (from the extension negotiation message), and a client and server may consequently end up with a connection for which some security features have been downgraded or disabled, aka a Terrapin attack. This occurs because the SSH Binary Packet Protocol (BPP), implemented by these extensions, mishandles the handshake phase and mishandles use of sequence numbers.

For example, there is an effective attack against SSH's use of ChaCha20-Poly1305 (and CBC with Encrypt-then-MAC). The bypass occurs in chacha20-poly1305@openssh.com and (if CBC is used) the -etm@openssh.com MAC algorithms. This also affects Maverick Synergy Java SSH API before 3.1.0-SNAPSHOT, Dropbear through 2022.83, Ssh before 5.1.1 in Erlang/OTP, PuTTY before 0.80, AsyncSSH before 2.14.2, golang.org/x/crypto before 0.17.0, libssh before 0.10.6, libssh2 through 1.11.0, Thorn Tech SFTP Gateway before 3.4.6, Tera Term before 5.1, Paramiko before 3.4.0, jsch before 0.2.15, SFTPGo before 2.5.6, Netgate pfSense Plus through 23.09.1, Netgate pfSense CE through 2.7.2, HPN-SSH through 18.2.0, ProFTPD before 1.3.8b (and before1.3.9rc2), ORYX CycloneSSH before 2.3.4, NetSarang XShell 7 before Build 0144, CrushFTP before 10.6.0, ConnectBot SSH library before 2.2.22, Apache MINA sshd through 2.11.0, sshj through 0.37.0, TinySSH through 20230101, trilead-ssh2 6401, the net-ssh gem 7.2.0 for Ruby, the mscdex ssh2 module before 1.15.0 for Node.js, the thrussh library before 0.35.1 for Rust, and the Russh crate before 0.40.2 for Rust; and there could be effects on Bitvise SSH through 9.31.

Vulnerable Library - ssh2-1.14.0.tgz

Describe what you expected

Are there any plans of upgrading ssh2 to the latest version 1.15.0?

Steps to reproduce the issue

No response

Additional context

No response

Command

None

itzsaga commented 7 months ago

This is coming up in our security scans as well.

Drarig29 commented 7 months ago

Thanks for reporting!

@anushreepatil @itzsaga can I ask which Vulnerability scanner you are both using?

itzsaga commented 7 months ago

@anushreepatil @itzsaga can I ask which Vulnerability scanner you are both using?

@Drarig29 Mend Bolt and it actually has identified a second one though something so far down in the dependency tree can be difficult to resolve.

Drarig29 commented 7 months ago

About word-wrap, when removing our internal yarn.lock file and reinstalling everything, I get:

$ yarn why -R word-wrap                                                  

└─ @datadog/datadog-ci@workspace:.
   └─ @google-cloud/run@npm:0.6.0 (via npm:^0.6.0)
      └─ google-gax@npm:3.6.1 (via npm:^3.5.8)
         └─ protobufjs-cli@npm:1.1.1 [c45ba] (via npm:1.1.1 [c45ba])
            └─ escodegen@npm:1.14.3 (via npm:^1.13.0)
               └─ optionator@npm:0.8.3 (via npm:^0.8.1)
                  └─ word-wrap@npm:1.2.5 (via npm:~1.2.3)

And upgrading @google-cloud/run fixes the issue. I will make a PR for that as well.

anushreepatil commented 7 months ago

Thanks for reporting!

@anushreepatil @itzsaga can I ask which Vulnerability scanner you are both using?

We are also using Mend.io. Thank you for the update!

DataDog / datadog-ci