DataDog / datadog-ci

Use Datadog from your CI.
https://datadoghq.com
Apache License 2.0
129 stars 55 forks source link

[SYNTH-14523] Only auto-discover with default glob when nothing given #1377

Closed Drarig29 closed 4 months ago

Drarig29 commented 4 months ago

What and why?

This PR fixes a regression introduced by #1214:

Before #1214

Passing a --public-id would disable the auto-discover → the specific overrides would not be loaded → the test wouldn't behave as expected ❌

After #1214

Passing a --public-id now keeps the auto-discover → config files containing the specific overrides are discovered → test A is run and configured properly ✅

The problem

Sadly, this came with a big performance impact when running datadog-ci from the user's home directory with just a --public-id parameter, because the CLI is traversing the whole disk (from the home directory).

How?

Go back to the previous behavior, unless --files is set explicitly:

Review checklist

datadog-datadog-prod-us1[bot] commented 4 months ago

Datadog Report

Branch report: corentin.girard/SYNTH-14523/only-auto-discover-with-default-glob-when-nothing-given Commit report: f6632f4 Test service: datadog-ci-tests

:white_check_mark: 0 Failed, 1572 Passed, 0 Skipped, 1m 51.4s Total duration (1m 36.28s time saved)