[SYNTH-15833] Use batch as source of truth for `hasResultPassed()`

DataDog / datadog-ci

Use Datadog from your CI.

https://datadoghq.com

Apache License 2.0

129 stars 55 forks source link

[SYNTH-15833] Use batch as source of truth for `hasResultPassed()` #1419

Closed Drarig29 closed 3 months ago

Drarig29 commented 3 months ago

What and why?

This PR fixes a bug where results without the complete information (server result from the polling endpoint) are reported as passed by default, even when the batch says the result failed.

How?

Change the source of truth for hasResultPassed() to be the ResultInBatch, instead of the ServerResult.

Review checklist

[x] Feature or bugfix MUST have appropriate tests (unit, integration)

datadog-datadog-prod-us1[bot] commented 3 months ago

Datadog Report

Branch report: corentin.girard/SYNTH-15833/bug-incomplete-results Commit report: 5af8f07 Test service: datadog-ci-tests

:white_check_mark: 0 Failed, 416 Passed, 0 Skipped, 52.79s Total duration (2m 34.89s time saved)