A Step Function can have multiple steps. Some steps may execute Lambda functions. Some steps may execute other Step Functions. When instrumenting a Step Function, we want to inject necessary context into both Lambda functions and child Step Functions.
Problem
If the last step doesn't need to be updated, e.g. if it's neither a Lambda function nor a Step Function, then context injection will be skipped. This is because the flag definitionHasBeenUpdated isn't updated properly.
What
Fix the usage of the flag so that if any part of definition is updated, this flag will be true.
Testing
Steps
Create a State Machine where
the Lambda step is not instrumented
the last step doesn't need to be updated
Instrument the Step Function by running datadog-ci stepfunctions instrument
Result
Before:
definitionHasBeenUpdated was false finally.
No change was applied.
After:
definitionHasBeenUpdated was true finally.
Changes were applied.
Review checklist
[ ] Feature or bugfix MUST have appropriate tests (unit, integration)
Background
A Step Function can have multiple steps. Some steps may execute Lambda functions. Some steps may execute other Step Functions. When instrumenting a Step Function, we want to inject necessary context into both Lambda functions and child Step Functions.
Problem
If the last step doesn't need to be updated, e.g. if it's neither a Lambda function nor a Step Function, then context injection will be skipped. This is because the flag
definitionHasBeenUpdatedisn't updated properly.What
Fix the usage of the flag so that if any part of definition is updated, this flag will be true.
Testing
Steps
datadog-ci stepfunctions instrumentResult
Before:
definitionHasBeenUpdatedwas false finally.After:
definitionHasBeenUpdatedwas true finally.Review checklist