DataDog / datadog-cloudformation-macro

CloudFormation Macros by Datadog
Apache License 2.0
14 stars 22 forks source link

Adds option to use the GovCloud lambda layer #15

Closed DylanLovesCoffee closed 4 years ago

DylanLovesCoffee commented 4 years ago

What does this PR do?

Adds the parameter of isGovCloud to have the GovCloud lambda layer be added to the user's functions.

Motivation

SLS-701 - the GovCloud layer has a different ARN to be accounted for.

Testing Guidelines

Added new unit tests to cover this case.

Additional Notes

Types of changes

Check all that apply

codecov-io commented 4 years ago

Codecov Report

Merging #15 into master will increase coverage by 1.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   87.64%   88.69%   +1.04%     
==========================================
  Files           7        7              
  Lines         340      345       +5     
  Branches       79       81       +2     
==========================================
+ Hits          298      306       +8     
+ Misses         21       20       -1     
+ Partials       21       19       -2     
Impacted Files Coverage Δ
serverless/src/env.ts 94.44% <ø> (ø)
serverless/src/index.ts 90.19% <100.00%> (ø)
serverless/src/layer.ts 98.07% <100.00%> (+6.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66c75f3...b6bc210. Read the comment docs.