DataDog / datadog-cloudformation-macro

CloudFormation Macros by Datadog
Apache License 2.0
14 stars 22 forks source link

Docs are ahead of the release #53

Closed inhumantsar closed 3 years ago

inhumantsar commented 3 years ago

Looks like yesterday's merge adding Secrets Manager support is already in the public docs but is not yet released: https://docs.datadoghq.com/serverless/libraries_integrations/macro/#configuration

Let's get that release out! I'm very excited to use it :)

Expected Behavior

Setting apiKeySecretArn would result in no errors.

Actual Behavior

DatadogServerless failed with: When extensionLayerVersion is set, apiKey or apiKmsKey must also be set.

Steps to Reproduce the Problem

  1. Set apiKeySecretArn in the DatadogServerless layer config
  2. sam deploy

Specifications

For the Datadog Serverless Macro:

duncanista commented 3 years ago

Hey @inhumantsar, sorry for the trouble. I'm now removing the feature from the docs, should be ready to go once we release the new version of the macro.

inhumantsar commented 3 years ago

😭 any idea when that release will be happening? i'm building out some boilerplate for a suite of new projects and would really like to use this, but if it's not going to be available soon then i'm going to have to rework things.

hghotra commented 3 years ago

Hey @inhumantsar, we'll make a release today within the next hour so you should be able to use it :)

duncanista commented 3 years ago

Hey @inhumantsar, we just released version 0.2.4. Thank you for opening the issue.

inhumantsar commented 3 years ago

🎉