DataDog / datadog-cloudformation-macro

CloudFormation Macros by Datadog
Apache License 2.0
14 stars 22 forks source link

feat: add `DD_APM_FLUSH_DEADLINE_MILLISECONDS` support #85

Closed duncanista closed 1 year ago

duncanista commented 1 year ago

What does this PR do?

Adds the field apmFlushDeadline which sets DD_APM_FLUSH_DEADLINE_MILLISECONDS. This field allows users to determine when to submit spans before a timeout.

Motivation

Configure custom deadline before a timeout. Which is available in both the tracers for Python and NodeJS.

Testing Guidelines

Added unit test.

Additional Notes

Also updated broken README.md

Types of changes

Check all that apply

codecov-commenter commented 1 year ago

Codecov Report

Merging #85 (9fd1b74) into master (ea21073) will increase coverage by 0.28%. The diff coverage is 100.00%.

:exclamation: Current head 9fd1b74 differs from pull request most recent head 6157c75. Consider uploading reports for the commit 6157c75 to get more accurate results

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   93.01%   93.29%   +0.28%     
==========================================
  Files           7        7              
  Lines         501      522      +21     
  Branches      117      124       +7     
==========================================
+ Hits          466      487      +21     
  Misses         26       26              
  Partials        9        9              
Impacted Files Coverage Δ
serverless/src/env.ts 97.32% <100.00%> (+0.61%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more