DataDog / datadog-for-vscode

Datadog for VS Code
https://marketplace.visualstudio.com/items?itemName=Datadog.datadog-vscode
Other
10 stars 1 forks source link

Support for workspaces #20

Open brettcurtis opened 1 week ago

brettcurtis commented 1 week ago

When using workspaces with multiple repos I get promoted for: image

In this case I already have a static-analysis.datadog.yml in the repo with golang and if I say yes it puts the file in the wrong repo.

m-paternostro commented 1 week ago

To be sure, you've opened multiple repositories in VS Code, right? If yes, just to make it easier to debug, do you mind sharing them?

image
brettcurtis commented 1 week ago

Correct my workspace looks like this: image

Here is the json if you want to test with the same workspace, all these repos are public:

{
        "folders": [
                {
                        "path": "../repos/osinfra-io/google-cloud-kubernetes"
                },
                {
                        "path": "../repos/osinfra-io/terraform-google-kubernetes-engine"
                },
                {
                        "path": "../repos/osinfra-io/gke-info-go"
                },
                {
                        "path": "../repos/osinfra-io/terraform-kubernetes-istio"
                },
                {
                        "path": "../repos/osinfra-io/terraform-kubernetes-datadog-operator"
                }
        ],
        "settings": {
                "github-actions.workflows.pinned.workflows": [
                        ".github/workflows/production.yml",
                        ".github/workflows/non-production.yml"
                ],
                "datadog.synthetics.tests.setup.linkedIds": [
                        "7be-dzr-f9b",
                        "87c-n3h-gxz",
                        "y8v-w92-ee7"
                ]
        }
}

Thanks for looking!

m-paternostro commented 1 week ago

At the moment we do not support multiple repositories for the Static Analysis feature - we do support it on other cases.

It shouldn't be too hard to do this properly, though ("famous last words" ;-)). I'll see what we can do.

m-paternostro commented 1 week ago

Unfortunately indeed a case of "famous last words". Reviewing the code, I see that it will be a fairly big work to properly support multiple repositories.

I will bring up the issue to the team and discuss prioritization. As it is now, static analysis only really works for the first root folder on a workspace.

Sorry for that. I will post here whenever we have news on this topic.

brettcurtis commented 1 week ago

No problem appreciate it!