Merge tags against existing tags in `WithTags` client option

DataDog / datadog-go

go dogstatsd client library for datadog

MIT License

353 stars 132 forks source link

Merge tags against existing tags in `WithTags` client option #278

Closed LINKIWI closed 1 year ago

LINKIWI commented 1 year ago

Fixes: #277

This change proposes that WithTags merges the specified tags against the existing set of default tags. This change impacts the behavior when the WithTags option is specified more than once against the same client.

See the above issue for a motivating example.

I also added a new unit test to cover the proposed behavior.

LINKIWI commented 1 year ago

@carlosroman Any chance you could help review this change? Thanks.