DataDog / datadog-go

go dogstatsd client library for datadog
MIT License
353 stars 132 forks source link

[CONTINT-3905] Make sure we retrieve the cgroup inode when the cid is not found #302

Closed AliDatadog closed 8 months ago

AliDatadog commented 8 months ago

This PR fixes an issue where the cgroup inode when the container id is "".

During testing of the last commit of this PR, we found out that the inode was sent and container tags was finally retrieved.

But actually, it was only because we had another bug in container id resolution that was fixed here. We were overriding a faulty container-id. We shouldn't override the container-id (actually it's not problematic). But we should at least retrieve the container-id when it's not found.

The new test cases should cover everything