DataDog / datadog-go

go dogstatsd client library for datadog
MIT License
353 stars 132 forks source link

Fix cgroup parsing in ECS Fargate #305

Closed sblumenthal closed 7 months ago

sblumenthal commented 7 months ago

The regex being used to parse ECS fargate container IDs is incorrect.

More details here: https://github.com/DataDog/datadog-agent/pull/24186

It looks like this is the only other place which uses this regex

It is worth noting that this should not really be an issue here, as this regex is used to parse the mountinfo file, and we are filtering for the existence of sandboxes which is unavailable in fargate, and the entry should be a regular docker ID in non-fargate ECS. So this PR should be more of a noop, but cleaning up a known non-working regex