search

DataDog / datadog-lambda-go

The Datadog AWS Lambda package for Go
Apache License 2.0
59 stars 40 forks source link

upgrade dd-trace-go to v1.41.0 or newer #114

Closed shota-hizawa closed 2 years ago

shota-hizawa commented 2 years ago

Expected Behavior

Running on Go v 1.19 is supported without errors.

Actual Behavior

I found the program got an error about gc and it exited with a panic. It seems to be related to dependent module dd-trace-go.

https://github.com/DataDog/datadog-lambda-go/blob/main/go.mod#L13

Please refer this resolved issue; https://github.com/DataDog/dd-trace-go/issues/1455

Specifications

Stacktrace

2022-09-09T15:31:31.249+09:00   panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.

2022-09-09T15:31:31.249+09:00   goroutine 1 [running]:

2022-09-09T15:31:31.249+09:00   go4.org/unsafe/assume-no-moving-gc.init.0()

2022-09-09T15:31:31.249+09:00   /go/pkg/mod/go4.org/unsafe/assume-no-moving-gc@v0.0.0-20211027215541-db492cf91b37/untested.go:25 +0x1f4

2022-09-09T15:31:31.250+09:00   EXTENSION Name: datadog-agent State: Registered Events: [INVOKE,SHUTDOWN]

2022-09-09T15:31:31.285+09:00   LOGS Name: datadog-agent State: Already subscribed Types: [platform,function,extension]
kimi-p commented 2 years ago

@shota-hizawa I have bump the dd-trace-go version and released. Thank you for letting us know!

shota-hizawa commented 2 years ago

Hi, @kimi-p Thank you! I'll try soon.