DataDog / datadog-lambda-go

The Datadog AWS Lambda package for Go
Apache License 2.0
59 stars 40 forks source link

Allow to set variables via datadog.yaml #120

Closed xrn closed 1 year ago

xrn commented 1 year ago

Expected Behavior

Would be cool if I can use

via datadog.yaml config for my lambdas - now I have 90% of DD configuration there but these if I am correct are not supported.

For me as a user is not clear and correct why DD_ENV could be move to yaml as env and is working but DD_VERSION can not be used as version there. Also second example DD_CAPTURE_LAMBDA_PAYLOAD works as capture_lambda_payload but DD_UNIVERSAL_INSTRUMENTATION does not

Also variable site - this is not clear for me:

  1. datadog-lambda-go has in config option to set site - but I can define it via datadog.yaml if I am using extension. Am I correct that if I have extension then does not matter what I will define in datadog-lambda-go site parameter? Or how it works?

Specifications

xrn commented 1 year ago

Following https://github.com/DataDog/datadog-lambda-go/pull/116#issuecomment-1370182747 I understand that DD_UNIVERSAL_INSTRUMENTATION will be not supported - but what about others?

tianchu commented 1 year ago

Closing the issue for now since we moved the convo to the community slack and resolved.