Closed nhinsch closed 3 years ago
Merging #84 (078c074) into main (a0a402d) will increase coverage by
0.71%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 82.45% 83.17% +0.71%
==========================================
Files 12 12
Lines 644 725 +81
==========================================
+ Hits 531 603 +72
- Misses 89 98 +9
Partials 24 24
Impacted Files | Coverage Δ | |
---|---|---|
ddlambda.go | 78.04% <0.00%> (-2.24%) |
:arrow_down: |
internal/trace/listener.go | 59.32% <0.00%> (-1.79%) |
:arrow_down: |
internal/metrics/kms_decrypter.go | 76.00% <0.00%> (-1.28%) |
:arrow_down: |
internal/metrics/time.go | 66.66% <0.00%> (ø) |
|
internal/metrics/batcher.go | 100.00% <0.00%> (ø) |
|
internal/metrics/context.go | 100.00% <0.00%> (ø) |
|
internal/wrapper/wrap_handler.go | 100.00% <0.00%> (ø) |
|
internal/metrics/listener.go | 75.53% <0.00%> (+1.12%) |
:arrow_up: |
internal/metrics/api.go | 90.00% <0.00%> (+1.32%) |
:arrow_up: |
internal/trace/context.go | 76.56% <0.00%> (+1.56%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a0a402d...078c074. Read the comment docs.
What does this PR do?
github.com/aws/aws-lambda-go
v1.11.1
->v1.25.0
github.com/aws/aws-sdk-go
v1.36.29
->v1.40.2
github.com/aws/aws-xray-sdk-go
v1.0.0-rc.9
->v1.6.0
vendor
directory that contained copies of dependencies. I am not sure if this directory was actually being used, as it was missing thevendor/modules.txt
manifest file. Either way, we don't really need to vendor our dependencies for this library; we can build by directly downloading dependencies from their sources like we do for our other libraries.Motivation
A community PR pointed out the need to upgrade
github.com/aws/aws-xray-sdk-go
. I decided to use this opportunity to update some other dependencies and clean up the vendor directory as well.Testing Guidelines
Unit and integration tests.
Types of changes
Checklist