DataDog / datadog-lambda-go

The Datadog AWS Lambda package for Go
Apache License 2.0
59 stars 40 forks source link

Set default sampling priority to sampler-keep #88

Closed agocs closed 3 years ago

agocs commented 3 years ago

What does this PR do?

Fixes #74. If datadog-lambda-go comes across a trace that does not have sampling-priority set, it should set a default priority (I think Tian decided on sampler-keep, but I will confirm.) This matches the behavior of other datadog-lambda-* libraries.

Motivation

Testing Guidelines

Additional Notes

Types of changes

Checklist

codecov-commenter commented 3 years ago

Codecov Report

Merging #88 (5d5d9a2) into main (d6fcbc3) will increase coverage by 0.25%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   84.93%   85.19%   +0.25%     
==========================================
  Files          13       13              
  Lines         770      770              
==========================================
+ Hits          654      656       +2     
+ Misses         91       90       -1     
+ Partials       25       24       -1     
Impacted Files Coverage Δ
internal/trace/context.go 78.12% <100.00%> (+1.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6fcbc3...5d5d9a2. Read the comment docs.