DataDog / datadog-lambda-go

The Datadog AWS Lambda package for Go
Apache License 2.0
59 stars 40 forks source link

[SLS-1260] Add functionname attribute to span metadata #89

Closed hghotra closed 3 years ago

hghotra commented 3 years ago

What does this PR do?

Add the functionname attribute to the Lambda span metadata.

Motivation

Look at problem 2 here: https://docs.google.com/document/d/1Jd40XCKibvhVntIiT02xjaZZlq3P2ohRHZ8VnKtu46Q/edit#

Testing Guidelines

Check the trace metadata tags to ensure the functionname attribute is present.

Additional Notes

Types of Changes

Check all that apply

codecov-commenter commented 3 years ago

Codecov Report

Merging #89 (bdfb945) into main (c88b4f4) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   84.93%   84.95%   +0.01%     
==========================================
  Files          13       13              
  Lines         770      771       +1     
==========================================
+ Hits          654      655       +1     
  Misses         91       91              
  Partials       25       25              
Impacted Files Coverage Δ
internal/trace/listener.go 59.01% <100.00%> (+0.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c88b4f4...bdfb945. Read the comment docs.