DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node
Apache License 2.0
113 stars 35 forks source link

feat: Move end span after children finish #345

Closed astuyve closed 1 year ago

astuyve commented 1 year ago

What does this PR do?

In theory the tracer will flush when all spans finish. I moved this just before merging this feature, but now think it best to move it back to my original location - after child nodes have been traced.

Motivation

Just in case, this should prevent us from attempting to flush after every module load span is created.

Testing Guidelines

Units and integration tests passing should suffice here.

Additional Notes

No

Types of Changes

Check all that apply