DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node
Apache License 2.0
109 stars 35 forks source link

feat: Modify end time of lambda load span to be last cold start node … #372

Closed astuyve closed 1 year ago

astuyve commented 1 year ago

…end time instead of start time of function.

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of Changes

Check all that apply

codecov-commenter commented 1 year ago

Codecov Report

Merging #372 (4c4891d) into main (35295b3) will increase coverage by 0.24%. The diff coverage is 75.94%.

:exclamation: Current head 4c4891d differs from pull request most recent head f0e253a. Consider uploading reports for the commit f0e253a to get more accurate results

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   80.35%   80.59%   +0.24%     
==========================================
  Files          36       38       +2     
  Lines        1761     1902     +141     
  Branches      410      439      +29     
==========================================
+ Hits         1415     1533     +118     
- Misses        294      312      +18     
- Partials       52       57       +5     
Impacted Files Coverage Δ
src/runtime/user-function.ts 7.69% <ø> (+7.69%) :arrow_up:
src/trace/listener.ts 64.70% <30.00%> (-3.48%) :arrow_down:
src/trace/context.ts 80.00% <57.89%> (-8.18%) :arrow_down:
src/trace/cold-start-tracer.ts 85.71% <85.71%> (ø)
src/runtime/require-tracer.ts 96.96% <96.96%> (ø)
src/index.ts 87.59% <100.00%> (+1.04%) :arrow_up:
src/runtime/index.ts 100.00% <100.00%> (+100.00%) :arrow_up:
src/trace/span-inferrer.ts 89.34% <100.00%> (+0.10%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more