feat: Bump dd-trace to 3.24 which includes fix for unhandled promise exceptions from lambda handlers - Githubissues

DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node

Apache License 2.0

113 stars 35 forks source link

feat: Bump dd-trace to 3.24 which includes fix for unhandled promise exceptions from lambda handlers #399

Closed astuyve closed 1 year ago

astuyve commented 1 year ago

What does this PR do?

fixes https://github.com/DataDog/dd-trace-js/issues/2893

Motivation

Testing Guidelines

Additional Notes

Types of Changes

[x] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

[x] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[x] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog
[ ] This PR passes the integration tests (ask a Datadog member to run the tests)

astuyve commented 1 year ago

@zARODz11z not quite, we install this as a dev dependency so that users can bring their own version of dd-trace if they install this library separately.

However, when we build the layers, we explicitly copy this dependency into the final docker build using this script