Path is removed by SAM CLI v1.89.

DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node

Apache License 2.0

109 stars 35 forks source link

Path is removed by SAM CLI v1.89. #401

Closed ruiwei closed 1 year ago

ruiwei commented 1 year ago

Expected Behavior

The handler is "/opt/nodejs/node_modules/datadog-lambda-js/handler.handler"

Actual Behavior

SAM CLI v1.89 removed the path, so it is "handler.handler" now. The example of using layer is not working anymore.

Specifications

Datadog Lambda Layer version: Any
Node version: Any

This is the bug report on SAM CLI https://github.com/aws/aws-sam-cli/issues/5429 https://github.com/aws/aws-sam-cli/pull/4216

astuyve commented 1 year ago

Hi @ruiwei - thanks for reaching out!

It seems like this is a bug in SAM and not Datadog, in fact after looking at the post you linked I'm not sure there's anything we can do except ask the AWS team to followup and offer a workaround for this, as it seems that this was a breaking change.

I've reached out to the SAM team and asked for more information, I'll get back to you when I hear more.

Thanks!

ruiwei commented 1 year ago

@astuyve Yeah. Can we keep this issue open? This may help other people in a similar situation. It took me a while to figure out why the SAM build did not work after being deployed by GitHub Actions.

astuyve commented 1 year ago

Sure thing, we'll keep this open until we can figure something out with SAM.

Thanks!

astuyve commented 1 year ago

This is released in AWS SAM 1.91.0