Closed astuyve closed 1 year ago
Merging #409 (2fa841a) into main (3764dad) will decrease coverage by
0.03%
. The diff coverage is57.14%
.:exclamation: Current head 2fa841a differs from pull request most recent head cebab54. Consider uploading reports for the commit cebab54 to get more accurate results
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
- Coverage 80.93% 80.91% -0.03%
==========================================
Files 38 38
Lines 1983 1986 +3
Branches 460 460
==========================================
+ Hits 1605 1607 +2
- Misses 319 320 +1
Partials 59 59
Impacted Files | Coverage Δ | |
---|---|---|
src/metrics/kms-service.ts | 82.14% <57.14%> (-1.86%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
What does this PR do?
Hopefully fixes #408
Motivation
I'm still testing this, want to get it on a PR for integration tests. But apparently our callpath try/catch isn't enough to convince esbuild that this library is provided externally.
Testing Guidelines
I build this project and then tested it locally with
npx esbuild dist/index.js --bundle --minify --platform=node
and did not receive any errors.For developers finding this in the future, you can test this is error-free by:
yarn install
node_modules/@aws-sdk
andnode_modules/aws-sdk
entirely! <- This step is KEY.yarn build
npx esbuild dist/index.js --bundle --minify --platform=node
and confirming you do not receive any build errors.An esbuild error looks like this:
Additional Notes
Types of Changes
Check all that apply