DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node
Apache License 2.0
109 stars 35 forks source link

Bump dd-trace version #425

Closed hjfitz closed 11 months ago

hjfitz commented 11 months ago

What does this PR do?

Bumps dd-trace from 3.x to 4.x

Motivation

When moving from using the library to the layer, we've noticed some instability and that the version differs by one major version

Testing Guidelines

Ran tests as a regression

Additional Notes

Types of Changes

Check all that apply

astuyve commented 11 months ago

Hey, sorry we're unable to accept this right now as ddtrace 4 dropped support for node14 which is still supported by this library.

DDtrace 3.x is still maintained, and we're happy to upgrade to the latest release. Can you share which specific issue you're facing?

Thanks!

hjfitz commented 11 months ago

Hey @astuyve - we've recently moved from using dd-trace in node_modules/ to using the layer, which was a downgrade from 4.x to 3.x. The move was due to switching to using Webpack.

The result here is that we're now seeing exceptionally long times for our lambda on occasion - anywhere from 8 minutes to 10 minutes. These instances are due to a request to kms timing out.

There's little to nothing in our Datadog instance surrounding it except for a call stack:

Error: Client network socket disconnected before secure TLS connection was established
    at connResetException (node:internal/errors:720:14)
    at TLSSocket.onConnectEnd (node:_tls_wrap:1605:19)
    at TLSSocket.emit (node:events:526:35)
    at TLSSocket.emit (/opt/nodejs/node_modules/dd-trace/packages/datadog-instrumentations/src/net.js:61:25)
    at endReadableNT (node:internal/streams/readable:1359:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

Edit: A bump to the latest 3.x would be a great start, at least 🙌

astuyve commented 11 months ago

Thanks for that context, it's super helpful! If you don't mind opening a new issue or support ticket with a reproducible example, I'd love to help troubleshoot that.

In the meantime, I've got an upgrade PR that we'll ship asap: https://github.com/DataDog/datadog-lambda-js/pull/426

I'm going to close this for now in favor of #426

Thanks again!

astuyve commented 11 months ago

This is now released in 7.99