DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node
Apache License 2.0
109 stars 35 forks source link

expose DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH [SVLS-3853] #430

Closed joeyzhao2018 closed 9 months ago

joeyzhao2018 commented 10 months ago

What does this PR do?

  1. Expose DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH environment variable. This is to achieve feature parity. Universal instrumentation already enabled the env: https://github.com/DataDog/datadog-agent/pull/19450
  2. Add a section in Readme file to serve as a doc for the environment variables introduced in this repo.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

Check all that apply

codecov-commenter commented 10 months ago

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (35295b3) 80.35% compared to head (8ed18b2) 81.27%. Report is 83 commits behind head on main.

:exclamation: Current head 8ed18b2 differs from pull request most recent head 9be5811. Consider uploading reports for the commit 9be5811 to get more accurate results

Files Patch % Lines
src/trace/step-function-service.ts 49.29% 35 Missing and 1 partial :warning:
src/trace/listener.ts 41.37% 17 Missing :warning:
src/trace/span-inferrer.ts 81.48% 0 Missing and 10 partials :warning:
src/trace/cold-start-tracer.ts 87.23% 2 Missing and 4 partials :warning:
src/trace/xray-service.ts 94.59% 5 Missing and 1 partial :warning:
src/trace/context/extractors/event-bridge-sqs.ts 61.53% 3 Missing and 2 partials :warning:
src/index.ts 90.47% 3 Missing and 1 partial :warning:
src/trace/context/extractor.ts 95.18% 4 Missing :warning:
src/trace/context/extractors/event-bridge.ts 63.63% 3 Missing and 1 partial :warning:
src/trace/context/extractors/kinesis.ts 69.23% 3 Missing and 1 partial :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #430 +/- ## ========================================== + Coverage 80.35% 81.27% +0.92% ========================================== Files 36 50 +14 Lines 1761 2040 +279 Branches 410 467 +57 ========================================== + Hits 1415 1658 +243 - Misses 294 322 +28 - Partials 52 60 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.