Fix invalid type imports

samchungy commented 9 months ago

What does this PR do?

Fixes invalid type imports introduced in https://github.com/DataDog/datadog-lambda-js/pull/429

Motivation

Datadog lambda js is throwing a build error: https://github.com/seek-oss/skuba/actions/runs/6992350107/job/19023877986?pr=1326#step:4:288

Testing Guidelines

Build using tsc/lint locally

Additional Notes

Types of Changes

[x] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

[x] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog
[ ] This PR passes the integration tests (ask a Datadog member to run the tests)

samchungy commented 9 months ago

Hey @astuyve could I get a ✅ on this one :) 🙏

astuyve commented 9 months ago

Hey I'm at re:Invent right now and can't look, but will ask someone to check in!

Thanks!

samchungy commented 9 months ago

Oh looks like those tests don't work for non datadog employees 😕. Not sure how to resolve this @duncanista . I also don't have merge perms 😛. Happy for you to just copy the changes into another branch if that works

duncanista commented 9 months ago

@samchungy I'll run them in my machine from this PR, they should pass from my point of view, so we can override that – if this is business critical for you, please raise a ticket with us so we can escalate and make a release for this, be sure to mention this PR, and this comment.

We normally wouldn't request this, but due to an active Code Freeze on our side, we are limited on the releases!

samchungy commented 9 months ago

@samchungy I'll run them in my machine from this PR, they should pass from my point of view, so we can override that – if this is business critical for you, please raise a ticket with us so we can escalate and make a release for this, be sure to mention this PR, and this comment.

We normally wouldn't request this, but due to an active Code Freeze on our side, we are limited on the releases!

All good, I understand. I'll just pin it on our side for now

astuyve commented 9 months ago

Thanks so much @samchungy!!!

DataDog / datadog-lambda-js