DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node
Apache License 2.0
109 stars 35 forks source link

feat: Skip the flush() call unless the DD_LOCAL_TEST env var is set #454

Closed astuyve closed 8 months ago

astuyve commented 8 months ago

What does this PR do?

Removes the call to /flush, as the telemetry-api tells us this information now

Fixes #452

Motivation

We'd like to remove this entirely but it's required for people using the extension in a local testing mode. We don't intend to further support local testing in this library at this time.

Testing Guidelines

Additional Notes

Types of Changes

Check all that apply

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (761b3dc) 82.06% compared to head (7440d6e) 82.09%.

:exclamation: Current head 7440d6e differs from pull request most recent head cde829b. Consider uploading reports for the commit cde829b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #454 +/- ## ========================================== + Coverage 82.06% 82.09% +0.03% ========================================== Files 54 54 Lines 2180 2184 +4 Branches 507 509 +2 ========================================== + Hits 1789 1793 +4 Misses 329 329 Partials 62 62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.