DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node
Apache License 2.0
107 stars 35 forks source link

fix: release script should exit on error. #504

Closed astuyve closed 5 months ago

astuyve commented 5 months ago

What does this PR do?

Prevents #503.

The new ci-based release logic never used set -e, and thus when tsc wasn't found, it published the typescript code (but not js) to npm: image

This PR should fix that, and installs tsc correctly.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

Check all that apply

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.10%. Comparing base (6a72730) to head (a3d36f4).

:exclamation: Current head a3d36f4 differs from pull request most recent head b39c50f. Consider uploading reports for the commit b39c50f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #504 +/- ## ======================================= Coverage 82.10% 82.10% ======================================= Files 54 54 Lines 2191 2191 Branches 511 511 ======================================= Hits 1799 1799 Misses 329 329 Partials 63 63 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.