DataDog / datadog-lambda-js

The Datadog AWS Lambda Library for Node
Apache License 2.0
110 stars 35 forks source link

breaking: Use sha256 to hash lambda traceId that are triggered by Step Functions and set _dd.p.tid #534

Closed kimi-p closed 4 months ago

kimi-p commented 5 months ago

What does this PR do?

Motivation

To support 128 bits trace IDs and to avoid showing up in security vulnerability scans, we are upgrading the hashing method (md5) to sha256.

Testing Guidelines

image

Additional Notes

This is a breaking change that will affect all current Step Functions public beta users. And what will break is the Step Functions trace and Lambda traces linking.

Since this has to be done at some point, we want to put this change out before GA. Serverless-Integrations team will work with Sumedha and have some sort of announcement to let customers know the exact cut off time so that they can deploy their Lambda around the same time.

Referencing PR for implementing MD5

Types of Changes

Check all that apply

kimi-p commented 4 months ago

I have verified after these change based on the comments that the spans linking still works in staging.

image