Closed joeyzhao2018 closed 4 months ago
Left some comments.
@duncanista 's comments made me take a closer look at the way i added debug logs. And after some thoughts I think it's best to use just one static string as the parameter and removed extra logging of the event payload or tracecontext. This is to avoid any extra memory allocation and keep the code cleaner. Based on my on-call experience, we usually get the event payload from other logs.
What does this PR do?
Extract trace context in SNS and SQS cases where the upstream service is instrumented by dd-trace-java In short,
Java => SNS => Lambda
, the env: _X_AMZN_TRACE_ID has the dd trace id but not the correct parent id. We will still use it here.Java => SQS => Lambda
orJava => SNS => SQS => Lambda
case, AWS propagate the trace context in the json payload attributes.Longer version:
Testing Guidelines
Batch Publish
Additional Notes
Types of Changes
Check all that apply