DataDog / datadog-lambda-rb

The Datadog AWS Lambda Layer for Ruby

Apache License 2.0

9 stars 8 forks source link

feat: Add support for Ruby 3.2 #76

Closed duncanista closed 1 year ago

duncanista commented 1 year ago

What does this PR do?

Updates gem to work with Ruby 3.2.

Motivation

AWS posted an image of AWS Lambda for Ruby 3.2 in their ECR gallery. And users have also raised an issue about the gem needed small changes to work.

70

74

Testing Guidelines

[x] Manual tests
[x] Unit tests
[x] Integration tests

Additional Notes

This PR also allows the user to use the Datadog Lambda Extension to send: logs, metrics, and traces, asynchronously.

Types of changes

[ ] Bug fix
[x] New feature
[ ] Breaking change
[x] Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

[ ] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

joeyzhao2018 commented 1 year ago

Integration test failed during docker build

0.234 exec /bin/sh: exec format error
#9 ERROR: executor failed running [/bin/sh -c apt-get update]: exit code: 1

I think this is usually from a mismatch between the architectures of the image and the host? So maybe we just need to provide the architecture param by changing this line to

docker buildx build -t datadog-lambda-layer-ruby:$1 . --no-cache \
        --build-arg "image=lambci/lambda:build-ruby${1}"  \
        --build-arg "runtime=${1}.0" \
        --platform linux/${arch} \