search

DataDog / datadog-operator

Kubernetes Operator for Datadog Resources
Apache License 2.0
301 stars 104 forks source link

Can't turn off APM for unwanted languages #1369

Open nikhilro opened 1 month ago

nikhilro commented 1 month ago

Describe what happened: In my operator, I'm using 

          apm: {
            enabled: true,
            instrumentation: {
              enabled: true, // default is false
              libVersions: {
                js: 'v5.19.0',
              },
            },
          },

I would expect only JS init container would be added to my deployments. Instead, I see all the init containers being attached.

Describe what you expected: I would expect only JS init container would be added to my deployments.

Steps to reproduce the issue:

          apm: {
            enabled: true,
            instrumentation: {
              enabled: true, // default is false
              libVersions: {
                js: 'v5.19.0',
              },
            },
          },

Additional environment details (Operating System, Cloud provider, etc): EKS, Kubernetes 1.30.0

There is likely some setting I'm missing. Appreciate the help.

aquiladayc commented 4 weeks ago

Hi @nikhilro Could replicate it with Cluster Agent version v7.49 or older. Do you use those? Will further look into github history but I confirmed it works with newer version. If so, please update the cluster agent to latest one. And you may need to set features.apm.instrumentation.enabledNamespaces too.

If you see further issue and need assistance, can you please share: Operator version: helm list | grep datadog DCA version and config: kubectl describe pod <cluster agent>

If you are uncomfortable to share it here or you want better tracking of this case, please feel free to reach support https://www.datadoghq.com/support/

nikhilro commented 4 weeks ago

I'm on 1.6.1 for Datadog Operator. Will try upgrading to 1.8.0, seems that's the latest: https://github.com/DataDog/datadog-operator/releases/tag/v1.8.0. Thanks

aquiladayc commented 4 weeks ago

what's cluster agent version?

nikhilro commented 4 weeks ago

gcr.io/datadoghq/cluster-agent:7.51.0