[CECO-1441] Use fully-qualified domain name finalizer

[tbavelier]

What does this PR do?

• Uses fully-qualified domain name on dashboard CRD per k8s convention : https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#finalizers

Identifiers of custom finalizers consist of a domain name, a forward slash and the name of the finalizer. Any controller can add a finalizer to any object's list of finalizers.

Motivation

• https://datadoghq.atlassian.net/browse/CECO-1441

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

• Agent: vX.Y.Z
• Cluster Agent: vX.Y.Z

Describe your test plan

• Covered by tests, but apply dashboard CR, ensure there are no logs from KubeAPIWarningLogger in the operator, then delete the CR with kubectl delete and ensure the CR is properly deleted

Checklist

• [x] PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
• [x] PR has a milestone or the qa/skip-qa label

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.40%. Comparing base (4c40ffd) to head (9f5e30c).

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## main #1397 +/- ## ======================================= Coverage 47.40% 47.40% ======================================= Files 223 223 Lines 19244 19244 ======================================= Hits 9123 9123 Misses 9635 9635 Partials 486 486 ``` | [Flag](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `47.40% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [internal/controller/datadogdashboard/finalizer.go](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397?src=pr&el=tree&filepath=internal%2Fcontroller%2Fdatadogdashboard%2Ffinalizer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-aW50ZXJuYWwvY29udHJvbGxlci9kYXRhZG9nZGFzaGJvYXJkL2ZpbmFsaXplci5nbw==) | `61.53% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [4c40ffd...9f5e30c](https://app.codecov.io/gh/DataDog/datadog-operator/pull/1397?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[tbavelier]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 15m.

Use /merge -c to cancel this operation!